[
https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832569#comment-16832569
]
Erik Krogen commented on HADOOP-16266:
--------------------------------------
Thanks [~csun], these were very helpful comments. I have addressed all of them
in v011.
{quote}
Question on RpcCall#isOpen - this is used to determine whether a call has been
processed or not, but is implemented using connection.channel.isOpen(), which
is a little confusing to me. Isn't a channel being used to serve multiple RPC
calls, and is only closed when you run into some errors or timed out? how can
it be used to indicate whether a call has been processed or not?
{quote}
I changed the name of this variable to be more illustrative, and added a
comment. Essentially this is checking if the connection was dropped (e.g. due
to timeout) while the call was in the queue. If so, the connection was closed,
and we did not end up doing any processing.
> Add more fine-grained processing time metrics to the RPC layer
> --------------------------------------------------------------
>
> Key: HADOOP-16266
> URL: https://issues.apache.org/jira/browse/HADOOP-16266
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Christopher Gregorian
> Assignee: Christopher Gregorian
> Priority: Minor
> Labels: rpc
> Attachments: HADOOP-16266.001.patch, HADOOP-16266.002.patch,
> HADOOP-16266.003.patch, HADOOP-16266.004.patch, HADOOP-16266.005.patch,
> HADOOP-16266.006.patch, HADOOP-16266.007.patch, HADOOP-16266.008.patch,
> HADOOP-16266.009.patch, HADOOP-16266.010.patch, HADOOP-16266.011.patch
>
>
> Splitting off of HDFS-14403 to track the first part: introduces more
> fine-grained measuring of how a call's processing time is split up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
