[ 
https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831993#comment-16831993
 ] 

Erik Krogen commented on HADOOP-16266:
--------------------------------------

Hey [~elgoiri], thanks for looking. I resolved all of your comments in v009 
except for the two about making the {{TIMEUNIT}} configurable and documenting 
it. We decided earlier on not to add the bits to make it configurable since the 
patch is already getting really large... I created HADOOP-16290 as a follow-up 
task to take care of these two things. Let me know if you take issue with this.

{quote}
Can we do some testing using the {{lockAndSleep()}} for the unit conversion?
{quote}
I changed the greater-than assertion to an equal-to assertion so that it will 
check that the units were converted correctly. Let me know if you think that's 
enough... I tried to think of some other things to do but unfortunately there's 
no way to get any of the other timings (lockexclusive, enqueue, etc.) at this 
level.

> Add more fine-grained processing time metrics to the RPC layer
> --------------------------------------------------------------
>
>                 Key: HADOOP-16266
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16266
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Christopher Gregorian
>            Assignee: Christopher Gregorian
>            Priority: Minor
>              Labels: rpc
>         Attachments: HADOOP-16266.001.patch, HADOOP-16266.002.patch, 
> HADOOP-16266.003.patch, HADOOP-16266.004.patch, HADOOP-16266.005.patch, 
> HADOOP-16266.006.patch, HADOOP-16266.007.patch, HADOOP-16266.008.patch
>
>
> Splitting off of HDFS-14403 to track the first part: introduces more 
> fine-grained measuring of how a call's processing time is split up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to