hanishakoneru commented on a change in pull request #884: HDDS-1620. Implement
Volume Write Requests to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/884#discussion_r292246118
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java
##########
@@ -180,6 +181,17 @@ protected OMResponse
createErrorOMResponse(OMResponse.Builder omResponse,
return omResponse.build();
}
+
+ /*
+ * This method sets the omRequest. This will method will be called when
Review comment:
I think Arpit means that we can have something like an execute() function
which calls preExecute() and updates omRequest with the result of preExecute.
This way we do not need to force implementations of preExecute to call
setUpdatedOmRequest().
And in OMProtocolServerSideTranslator, we would call this execute() function
instead of preExecute().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
