hanishakoneru commented on a change in pull request #884: HDDS-1620. Implement Volume Write Requests to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/884#discussion_r292249421
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeCreateRequest.java ########## @@ -0,0 +1,209 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.request.volume; + +import java.io.IOException; + +import com.google.common.base.Optional; +import com.google.common.base.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hadoop.ozone.audit.AuditLogger; +import org.apache.hadoop.ozone.audit.OMAction; +import org.apache.hadoop.ozone.om.response.volume.OMVolumeCreateResponse; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos; +import org.apache.hadoop.utils.db.cache.CacheKey; +import org.apache.hadoop.utils.db.cache.CacheValue; +import org.apache.hadoop.ozone.om.OMMetrics; +import org.apache.hadoop.ozone.om.OMMetadataManager; +import org.apache.hadoop.ozone.om.OzoneManager; +import org.apache.hadoop.ozone.om.exceptions.OMException; +import org.apache.hadoop.ozone.om.helpers.OmVolumeArgs; +import org.apache.hadoop.ozone.om.request.OMClientRequest; +import org.apache.hadoop.ozone.om.response.OMClientResponse; +import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer; +import org.apache.hadoop.ozone.security.acl.OzoneObj; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .CreateVolumeRequest; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .CreateVolumeResponse; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .OMRequest; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .OMResponse; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .VolumeInfo; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .VolumeList; +import org.apache.hadoop.util.Time; + +/** + * Handles volume create request. + */ +public class OMVolumeCreateRequest extends OMClientRequest { + private static final Logger LOG = + LoggerFactory.getLogger(OMVolumeCreateRequest.class); + + public OMVolumeCreateRequest(OMRequest omRequest) { + super(omRequest); + } + + @Override + public OMRequest preExecute(OzoneManager ozoneManager) throws IOException { + + VolumeInfo volumeInfo = + getOmRequest().getCreateVolumeRequest().getVolumeInfo(); + + // Set creation time + VolumeInfo updatedVolumeInfo = + volumeInfo.toBuilder().setCreationTime(Time.now()).build(); + + // Update the OmRequest and then return it. + setUpdatedOmRequest(getOmRequest().toBuilder().setCreateVolumeRequest( + CreateVolumeRequest.newBuilder().setVolumeInfo(updatedVolumeInfo)) + .setUserInfo(getUserInfo()) + .build()); + + return getOmRequest(); + + } + + @Override + public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, + long transactionLogIndex) { + + CreateVolumeRequest createVolumeRequest = + getOmRequest().getCreateVolumeRequest(); + Preconditions.checkNotNull(createVolumeRequest); + VolumeInfo volumeInfo = createVolumeRequest.getVolumeInfo(); + + OMMetrics omMetrics = ozoneManager.getMetrics(); + omMetrics.incNumVolumeCreates(); + + String volume = volumeInfo.getVolume(); + String owner = volumeInfo.getOwnerName(); + + OMResponse.Builder omResponse = OMResponse.newBuilder().setCmdType( + OzoneManagerProtocolProtos.Type.CreateVolume).setStatus( + OzoneManagerProtocolProtos.Status.OK).setSuccess(true); + + OmVolumeArgs omVolumeArgs = null; + + OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager(); + + AuditLogger auditLogger = ozoneManager.getAuditLogger(); + OzoneManagerProtocolProtos.UserInfo userInfo = getOmRequest().getUserInfo(); + + // Doing this here, so we can do protobuf conversion outside of lock. + try { + omVolumeArgs = OmVolumeArgs.getFromProtobuf(volumeInfo); + } catch (OMException ex) { + omMetrics.incNumVolumeCreateFails(); + auditLog(auditLogger, buildAuditMessage(OMAction.CREATE_VOLUME, + buildVolumeAuditMap(volume), ex, userInfo)); + LOG.error("Volume creation failed for user:{} volume:{}", owner, volume, + ex); + return new OMVolumeCreateResponse(omVolumeArgs, null, + createErrorOMResponse(omResponse, ex)); + } + + + + try { Review comment: Can we combine this try block with the previous try block. Both the catch blocks are similar. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
