hanishakoneru commented on a change in pull request #884: HDDS-1620. Implement
Volume Write Requests to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/884#discussion_r292239483
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
##########
@@ -189,53 +188,21 @@ public void
notifyNotLeader(Collection<TransactionContext> pendingEntries)
private TransactionContext handleStartTransactionRequests(
RaftClientRequest raftClientRequest, OMRequest omRequest) {
- OMRequest newOmRequest = null;
- try {
- switch (omRequest.getCmdType()) {
- case CreateVolume:
- case SetVolumeProperty:
- case DeleteVolume:
- newOmRequest = handler.handleStartTransaction(omRequest);
Review comment:
handleStartTransaction() method is no longer called anywhere. We can remove
this method?
Or are you planning to cleanup unused methods in a separate Jira?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
