[
https://issues.apache.org/jira/browse/HADOOP-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083474#comment-13083474
]
Aaron T. Myers commented on HADOOP-7380:
----------------------------------------
{quote}
I am concerned about the idempotent operation part of the patch.
This is a significant change and it would be good to describe and discuss this.
Aaron could you please provide a short description in this Jira.
{quote}
Sure, I'll write something up.
bq. Also shouldn't this be going into the HA branch?
As I've already said:
{quote}
Eli seemed to think this change was sufficiently generic that it could go into
trunk before the HA branch was cut. I'm inclined to agree with him, but if you
feel strongly, we could certainly back it out of trunk and commit it only to
the HA branch. I don't see much benefit in doing so versus just addressing any
concerns you have in subsequent patches, but I don't feel strongly about that.
{quote}
Please let me know if you want me to do that.
bq. As we use it with NN failover this will need to be refined.
I'm sure it will. Do you have any specific changes in mind? If so, I'd be happy
to file follow-up JIRAs to address them.
bq. Further it will require a test plan that we can develop a part of the HA
branch.
A test plan for just this patch beyond the tests which were included as part of
this patch? What are you looking for out of said test plan? I certainly agree
that we should come up with a test plan for the entirety of the HA work, but I
don't think that has much to do with this specific patch.
> Add client failover functionality to o.a.h.io.(ipc|retry)
> ---------------------------------------------------------
>
> Key: HADOOP-7380
> URL: https://issues.apache.org/jira/browse/HADOOP-7380
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hadoop-7380-hdfs-example.patch, hadoop-7380.0.patch,
> hadoop-7380.1.patch, hadoop-7380.2.patch, hdfs-7380.3.patch
>
>
> Implementing client failover will likely require changes to {{o.a.h.io.ipc}}
> and/or {{o.a.h.io.retry}}. This JIRA is to track those changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
