vinayakumarb commented on a change in pull request #1432: HADOOP-16557.
[pb-upgrade] Upgrade protobuf.version to 3.7.1
URL: https://github.com/apache/hadoop/pull/1432#discussion_r325079179
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
##########
@@ -55,6 +55,7 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-annotations</artifactId>
</dependency>
+
Review comment:
> I guess the deprecation warnings should be handled in a follow-up patch as
you mentioned in the conversation in the jira.
Since all warnings are in generated code and still we want to use "proto2"
syntax for generated code, I guess these will stay.
>change in hadoop-yarn-api
This is intentional change to include hadoop-yarn-api during jenkins test.
During patch compilation "hadoop-yarn-common" was referring to
hadoop-yarn-api, and without this hadoop-yarn-api will have old generated code.
Because of which hadoop-yarn-common compilation was failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
