vinayakumarb commented on a change in pull request #1432: HADOOP-16557.
[pb-upgrade] Upgrade protobuf.version to 3.7.1
URL: https://github.com/apache/hadoop/pull/1432#discussion_r325323930
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -3274,18 +3274,18 @@ private void setupResponse(RpcCall call,
cos.writeRawByte((byte)((length >>> 16) & 0xFF));
cos.writeRawByte((byte)((length >>> 8) & 0xFF));
cos.writeRawByte((byte)((length >>> 0) & 0xFF));
- cos.writeRawVarint32(header.getSerializedSize());
+ cos.writeUInt32NoTag(header.getSerializedSize());
header.writeTo(cos);
if (payload != null) {
- cos.writeRawVarint32(payload.getSerializedSize());
+ cos.writeUInt32NoTag(payload.getSerializedSize());
Review comment:
Ditto :) All variations of *\*RawVarint\*()* APIs are deprecated and
replaced with *\*UInt\*NoTag()* APIs.
Deprecated APIs internally call *\*UInt\*NoTag()* API itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
