vinayakumarb commented on a change in pull request #1432: HADOOP-16557.
[pb-upgrade] Upgrade protobuf.version to 3.7.1
URL: https://github.com/apache/hadoop/pull/1432#discussion_r325325239
##########
File path: hadoop-client-modules/hadoop-client-runtime/pom.xml
##########
@@ -229,6 +229,13 @@
<exclude>update*</exclude>
</excludes>
</filter>
+ <filter>
+ <artifact>com.google.protobuf:protobuf-java</artifact>
+ <excludes>
+ <exclude>google/protobuf/*.proto</exclude>
+ <exclude>google/protobuf/**/*.proto</exclude>
+ </excludes>
+ </filter>
Review comment:
proto files are excluded from shading.
.5.0 protobuf jar didnt have proto files in jars. 3.7.1 jar jar have proto
files, so shaded jar verifier was complaining about unwanted content in shaded
jars.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
