steveloughran commented on a change in pull request #1795: HADOOP-16792: Make
S3 client request timeout configurable
URL: https://github.com/apache/hadoop/pull/1795#discussion_r363770709
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java
##########
@@ -390,6 +390,19 @@ public void testCustomUserAgent() throws Exception {
awsConf.getUserAgentPrefix());
}
+ @Test
+ public void testRequestTimeout() throws Exception {
+ conf = new Configuration();
+ conf.setInt(REQUEST_TIMEOUT, 10);
+ fs = S3ATestUtils.createTestFileSystem(conf);
+ assertNotNull(fs);
+ AmazonS3 s3 = fs.getAmazonS3ClientForTesting("Request timeout");
+ assertNotNull(s3);
+ ClientConfiguration awsConf = getField(s3, ClientConfiguration.class,
+ "clientConfiguration");
+ assertEquals(10, awsConf.getRequestTimeout());
Review comment:
needs a message indicating what doesn't match
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
