mustafaiman commented on a change in pull request #1795: HADOOP-16792: Make S3
client request timeout configurable
URL: https://github.com/apache/hadoop/pull/1795#discussion_r368058613
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java
##########
@@ -1284,7 +1284,10 @@ public static void initConnectionSettings(Configuration
conf,
DEFAULT_SOCKET_SEND_BUFFER, 2048);
int sockRecvBuffer = intOption(conf, SOCKET_RECV_BUFFER,
DEFAULT_SOCKET_RECV_BUFFER, 2048);
+ int requestTimeoutMillis = intOption(conf, REQUEST_TIMEOUT,
Review comment:
Configuration.getTimeDuration() returns a long and awsConf.setRequestTimeout
takes an int. Is there another common utility method to fail-fast a lossy
conversion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
