steveloughran commented on a change in pull request #1795: HADOOP-16792: Make S3 client request timeout configurable URL: https://github.com/apache/hadoop/pull/1795#discussion_r368079266
########## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java ########## @@ -390,6 +390,19 @@ public void testCustomUserAgent() throws Exception { awsConf.getUserAgentPrefix()); } + @Test + public void testRequestTimeout() throws Exception { + conf = new Configuration(); + conf.setInt(REQUEST_TIMEOUT, 11895); + fs = S3ATestUtils.createTestFileSystem(conf); + assertNotNull(fs); Review comment: you don't need these; not given an NPE is raised immediately after ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org