[
https://issues.apache.org/jira/browse/HADOOP-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203062#comment-17203062
]
Xiaoqiao He commented on HADOOP-17280:
--------------------------------------
Thanks [~LiJinglun] for your works. [^HADOOP-17280.004.patch] is almost good to
me. Just nit comments.
A. Please add some javadocs for method #testServiceUsersCase1 if want to change
the name.
B. For annotation, It is better use /** some notes */ format for method and //
for line comments. Another one, it is good practice to use upper case letter of
first words for annotation.
C. +1 for `Could you add documents to FairCallQueue.md and core-default.xml`.
Thanks [~LiJinglun].
> Service-user cost shouldn't be accumulated to totalDecayedCallCost and
> totalRawCallCost.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-17280
> URL: https://issues.apache.org/jira/browse/HADOOP-17280
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HADOOP-17280.001.patch, HADOOP-17280.002.patch,
> HADOOP-17280.003.patch, HADOOP-17280.004.patch
>
>
> HADOOP-17165 has introduced a very useful feature: service-user. After this
> feature I think we shouldn't add the service-user's cost into
> totalDecayedCallCost and totalRawCallCost anymore. Because it may give all
> the identities the priority 0(Supposing we have a big service-user).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
