[
https://issues.apache.org/jira/browse/HADOOP-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203823#comment-17203823
]
Takanobu Asanuma commented on HADOOP-17280:
-------------------------------------------
[~LiJinglun] Thanks for updating the patch.
bq. Could you be more specific
It is one very minor nit. I meant, please unify to
{code}
scheduler.getTotalCallVolume()
scheduler.getTotalRawCallVolume()
scheduler.getTotalServiceUserCallVolume()
scheduler.getTotalServiceUserRawCallVolume()
{code}
or
{code}
scheduler.getTotalCallVolume()
scheduler.getTotalServiceUserCallVolume()
scheduler.getTotalRawCallVolume()
scheduler.getTotalServiceUserRawCallVolume()
{code}
> Service-user cost shouldn't be accumulated to totalDecayedCallCost and
> totalRawCallCost.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-17280
> URL: https://issues.apache.org/jira/browse/HADOOP-17280
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HADOOP-17280.001.patch, HADOOP-17280.002.patch,
> HADOOP-17280.003.patch, HADOOP-17280.004.patch, HADOOP-17280.005.patch
>
>
> HADOOP-17165 has introduced a very useful feature: service-user. After this
> feature I think we shouldn't add the service-user's cost into
> totalDecayedCallCost and totalRawCallCost anymore. Because it may give all
> the identities the priority 0(Supposing we have a big service-user).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
