[
https://issues.apache.org/jira/browse/HADOOP-17288?focusedWorklogId=496858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496858
]
ASF GitHub Bot logged work on HADOOP-17288:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/20 19:03
Start Date: 07/Oct/20 19:03
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2342:
URL: https://github.com/apache/hadoop/pull/2342#discussion_r501244056
##########
File path: hadoop-common-project/hadoop-auth/pom.xml
##########
@@ -234,6 +235,24 @@
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.google.code.maven-replacer-plugin</groupId>
+ <artifactId>replacer</artifactId>
+ <executions>
+ <execution>
+ <id>replace-sources</id>
+ <configuration>
+ <skip>false</skip>
+ </configuration>
+ </execution>
+ <execution>
+ <id>replace-test-sources</id>
+ <configuration>
+ <skip>false</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
Thanx @vinayakumarb and @saintstack
Since the discussion is going on here, I thought to get everything here only.
Regarding guava revert to 11, I think, as you mentioned that would be
incompatible, and downstream would be excluding them only, when adding
hadoop-jars as dependency. So, In the present state there won't be any problem
with the version, since the hadoop jars aren't using it, and for the other
dependencies they are not getting affected by this version, as tests passed
both with 27 and 11. So, I think we can keep guava version as is and let
downstream exclude while including hadoop-jars(most projects already do that)
and run happily with there own guava versions.
Since reverting back would be problem for those, who don't have there own
guava and rely on hadoop to provide guava, there code might break.
So, I think we can keep the reversal separate from shading and if the
community is OK with going back, we will revert back in a separate jira
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 496858)
Time Spent: 1h (was: 50m)
> Use shaded guava from thirdparty
> --------------------------------
>
> Key: HADOOP-17288
> URL: https://issues.apache.org/jira/browse/HADOOP-17288
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Use the shaded version of guava in hadoop-thirdparty
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
