[
https://issues.apache.org/jira/browse/HADOOP-17288?focusedWorklogId=496890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496890
]
ASF GitHub Bot logged work on HADOOP-17288:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/20 19:34
Start Date: 07/Oct/20 19:34
Worklog Time Spent: 10m
Work Description: saintstack commented on a change in pull request #2342:
URL: https://github.com/apache/hadoop/pull/2342#discussion_r501260800
##########
File path: hadoop-common-project/hadoop-auth/pom.xml
##########
@@ -234,6 +235,24 @@
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.google.code.maven-replacer-plugin</groupId>
+ <artifactId>replacer</artifactId>
+ <executions>
+ <execution>
+ <id>replace-sources</id>
+ <configuration>
+ <skip>false</skip>
+ </configuration>
+ </execution>
+ <execution>
+ <id>replace-test-sources</id>
+ <configuration>
+ <skip>false</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
@vinayakumarb
> Since we commit the replaced code itself...
Good.
Ok on the isolation of grpc and dependencis (Can later try shading grpc
later if a problem)
Thanks for update on curator (shading curator would be a pain. It does
shading itself IIRC). Hive also has guava 11 in its API apparently.
> We are fortunate enough that, these dependencies are not part of any
exposed APIs.
Amen
@ayushtkn
> So, I think we can keep guava version as is ...
At 27? (Or at 11). Sorry, had trouble grokking here.
> Since reverting back would be problem for those, who don't have there own
guava and rely on hadoop to provide guava, there code might break.
I think this would be ok -- i.e. breakage -- especially in a new minor
version, 3.4.0. The fix is easy enough for the downstream, just add guava
dependency.
>
So, I think we can keep the reversal separate from shading and if the
community is OK with going back, we will revert back in a separate jira
Sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 496890)
Time Spent: 1h 10m (was: 1h)
> Use shaded guava from thirdparty
> --------------------------------
>
> Key: HADOOP-17288
> URL: https://issues.apache.org/jira/browse/HADOOP-17288
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Use the shaded version of guava in hadoop-thirdparty
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
