[
https://issues.apache.org/jira/browse/HADOOP-17288?focusedWorklogId=499524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499524
]
ASF GitHub Bot logged work on HADOOP-17288:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/20 16:56
Start Date: 12/Oct/20 16:56
Worklog Time Spent: 10m
Work Description: saintstack commented on a change in pull request #2342:
URL: https://github.com/apache/hadoop/pull/2342#discussion_r503413775
##########
File path: Jenkinsfile
##########
@@ -23,7 +23,7 @@ pipeline {
options {
buildDiscarder(logRotator(numToKeepStr: '5'))
- timeout (time: 20, unit: 'HOURS')
+ timeout (time: 30, unit: 'HOURS')
Review comment:
This change intentional? How does it relate?
##########
File path: hadoop-common-project/hadoop-common/pom.xml
##########
@@ -49,6 +49,12 @@
<artifactId>hadoop-annotations</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop.thirdparty</groupId>
+ <artifactId>hadoop-shaded-guava</artifactId>
+ <scope>compile</scope>
Review comment:
nit: no need of the compile scope since it default?
##########
File path: hadoop-common-project/hadoop-common/pom.xml
##########
@@ -49,6 +49,12 @@
<artifactId>hadoop-annotations</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop.thirdparty</groupId>
+ <artifactId>hadoop-shaded-guava</artifactId>
+ <scope>compile</scope>
+ </dependency>
+ <!--Guava is required during runtime for curator-->
Review comment:
Helpful comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 499524)
Time Spent: 1h 50m (was: 1h 40m)
> Use shaded guava from thirdparty
> --------------------------------
>
> Key: HADOOP-17288
> URL: https://issues.apache.org/jira/browse/HADOOP-17288
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Use the shaded version of guava in hadoop-thirdparty
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
