anoopsjohn commented on pull request #2646: URL: https://github.com/apache/hadoop/pull/2646#issuecomment-774959132
> Production code looks good. Added some comments in tests. > Also pending checkstyle > `./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsPread.java:43: int dataSize = 100;:20: '100' is a magic number. [MagicNumber] ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsPread.java:44: byte[] data = ContractTestUtils.dataset(dataSize, 'a', 26);:60: '26' is a magic number. [MagicNumber]` Corrected. These checkstyle should be applied for test code also? In tests these usage looks normal. Anyways handled by making static final. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
