steveloughran commented on pull request #2646:
URL: https://github.com/apache/hadoop/pull/2646#issuecomment-779442776


   > Corrected. These checkstyle should be applied for test code also? In tests 
these usage looks normal. Anyways handled by making static final.
   
   it's annoying, because its only tests, but it is nice to keep checkstyle 
under control. 
   
   Looking at the tests though: I don't see how making it static would help?.
   
   +1 from me. @surendralilhore : commit at will


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to