ayushtkn commented on a change in pull request #3240:
URL: https://github.com/apache/hadoop/pull/3240#discussion_r677993164
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractDistCp.java
##########
@@ -59,42 +55,35 @@ protected Configuration createConfiguration() {
return newConf;
}
+ @Override
+ protected boolean directWriteAlways() {
+ return true;
+ }
+
@Override
protected S3AContract createContract(Configuration conf) {
return new S3AContract(conf);
}
- /**
- * Always inject the delay path in, so if the destination is inconsistent,
- * and uses this key, inconsistency triggered.
- * @param filepath path string in
- * @return path on the remote FS for distcp
- * @throws IOException IO failure
- */
@Override
- protected Path path(final String filepath) throws IOException {
- Path path = super.path(filepath);
- return new Path(path, FailureInjectionPolicy.DEFAULT_DELAY_KEY_SUBSTRING);
+ public void testDistCpWithIterator() throws Exception {
+ final long renames = getRenameOperationCount();
+ super.testDistCpWithIterator();
+ assertEquals("Expected no renames for a direct write distcp",
+ getRenameOperationCount(),
+ renames);
}
@Override
public void testDirectWrite() throws Exception {
- final long renames = getRenameOperationCount();
- super.testDirectWrite();
- assertEquals("Expected no renames for a direct write distcp", 0L,
- getRenameOperationCount() - renames);
+ skip("Not needed as all tests are direct by default");
}
@Override
public void testNonDirectWrite() throws Exception {
+// ContractTestUtils.skip("disabled for peformance reasons");
Review comment:
can delete this line itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
