steveloughran commented on a change in pull request #3240:
URL: https://github.com/apache/hadoop/pull/3240#discussion_r678227498
##########
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java
##########
@@ -532,13 +549,15 @@ private Path distCpDeepDirectoryStructure(FileSystem
srcFS,
*/
private void largeFiles(FileSystem srcFS, Path srcDir, FileSystem dstFS,
Path dstDir) throws Exception {
+ int fileSizeKb = conf.getInt(SCALE_TEST_DISTCP_FILE_SIZE_KB,
+ DEFAULT_DISTCP_SIZE_KB);
+ if (fileSizeKb < 1) {
+ skip("File size in " + SCALE_TEST_DISTCP_FILE_SIZE_KB + " too small");
Review comment:
now
"File size in " + SCALE_TEST_DISTCP_FILE_SIZE_KB + " is zero
It's not bug, just a fact...for HDFS suite it'll be zero by default now
##########
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java
##########
@@ -612,6 +634,9 @@ public void testDirectWrite() throws Exception {
@Test
public void testNonDirectWrite() throws Exception {
+ if (directWriteAlways()) {
+ skip("not needed");
Review comment:
actually, it should be in the previous test. So moved up. thanks for
drawing my attention to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
