steveloughran commented on a change in pull request #3240:
URL: https://github.com/apache/hadoop/pull/3240#discussion_r678208290
##########
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java
##########
@@ -758,7 +828,7 @@ public void testDistCpWithUpdateExistFile() throws
Exception {
verifyPathExists(remoteFS, "", source);
verifyPathExists(localFS, "", dest);
DistCpTestUtils.assertRunDistCp(DistCpConstants.SUCCESS, source.toString(),
- dest.toString(), "-delete -update", conf);
+ dest.toString(), "-delete -update" + getDefaultCLIOptions(), conf);
Review comment:
did think about it, but I also felt that it might be prudent to have
tests with the CLI to parse, so make sure that -direct is handled there
properly. We've been hit in the past by some failures with s3guard and the FS
shell API because we were always working at the API level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
