[ 
https://issues.apache.org/jira/browse/HADOOP-17921?focusedWorklogId=652993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652993
 ]

ASF GitHub Bot logged work on HADOOP-17921:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Sep/21 14:24
            Start Date: 20/Sep/21 14:24
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on pull request #3463:
URL: https://github.com/apache/hadoop/pull/3463#issuecomment-922977734


   1. Is the current behaviour actually causing a problem? 
   1. Have you looked at all the implementations of fs.getXAttrs() and verified 
that they always throw UnsupportedOperationException if unsupported.
   
   I can see from a purism perspective this is the correct thing to do. But I 
worry that changing it now will break things.
   
   After all, if an IOE is raised here for some reason (network, auth etc) 
distcp will go on to fail shortly afterwards


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 652993)
    Time Spent: 20m  (was: 10m)

> DistCp derives if XAttr is supported wrongly
> --------------------------------------------
>
>                 Key: HADOOP-17921
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17921
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Pravin Sinha
>            Assignee: Pravin Sinha
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {color:#0033b3}public static void 
> {color}{color:#00627a}checkFileSystemXAttrSupport{color}({color:#000000}FileSystem
>  {color}fs)
>  {color:#0033b3}throws {color}{color:#000000}XAttrsNotSupportedException 
> {color}{
>  {color:#0033b3}try {color}{
>  fs.getXAttrs({color:#0033b3}new 
> {color}Path({color:#000000}Path{color}.{color:#871094}SEPARATOR{color}));
>  } {color:#0033b3}catch {color}({color:#000000}Exception {color}e) {
>  {color:#0033b3}throw new 
> {color}XAttrsNotSupportedException({color:#067d17}"XAttrs not supported for 
> file system: "
> {color} + fs.getUri());
>  }
> }
> IOExecption will also be treated as if Xattr is not supported, which would be 
> wrong.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to