[ 
https://issues.apache.org/jira/browse/HADOOP-17921?focusedWorklogId=659138&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-659138
 ]

ASF GitHub Bot logged work on HADOOP-17921:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Oct/21 20:31
            Start Date: 01/Oct/21 20:31
    Worklog Time Spent: 10m 
      Work Description: cnauroth commented on pull request #3463:
URL: https://github.com/apache/hadoop/pull/3463#issuecomment-932531983


   My only other thought is that this sort of logic is the kind of thing that 
should eventually make its way over to using `PathCapabilities`.  For complete 
accuracy though, the HDFS client implementation would need its 
`hasPathCapability` implementation to have knowledge of whether or not the 
remote NameNode has xattrs enabled.  Considering federation, you might even 
have different namespaces enabled or disabled, so the final answer is dependent 
on the path presented by the caller.  We could avoid that complexity if we 
removed the configuration property for disabling xattrs.  (It's a stable 
feature at this point.)  That would be a backward-incompatible change though.
   
   I've tried more brainstorming on this, and unfortunately, I can't think of a 
solution with high confidence in guaranteeing backward compatibility.
   
   We've focused discussion on xattrs so far, but there is similar logic for 
ACLs too that is susceptible to the same problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 659138)
    Time Spent: 1h 50m  (was: 1h 40m)

> DistCp derives if XAttr is supported wrongly
> --------------------------------------------
>
>                 Key: HADOOP-17921
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17921
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Pravin Sinha
>            Assignee: Pravin Sinha
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> {color:#0033b3}public static void 
> {color}{color:#00627a}checkFileSystemXAttrSupport{color}({color:#000000}FileSystem
>  {color}fs)
>  {color:#0033b3}throws {color}{color:#000000}XAttrsNotSupportedException 
> {color}{
>  {color:#0033b3}try {color}{
>  fs.getXAttrs({color:#0033b3}new 
> {color}Path({color:#000000}Path{color}.{color:#871094}SEPARATOR{color}));
>  } {color:#0033b3}catch {color}({color:#000000}Exception {color}e) {
>  {color:#0033b3}throw new 
> {color}XAttrsNotSupportedException({color:#067d17}"XAttrs not supported for 
> file system: "
> {color} + fs.getUri());
>  }
> }
> IOExecption will also be treated as if Xattr is not supported, which would be 
> wrong.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to