virajjasani commented on a change in pull request #3505: URL: https://github.com/apache/hadoop/pull/3505#discussion_r720122621
########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VisibleForTesting.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.util; + +/** + * Annotates a program element that exists, or is more widely visible than + * otherwise necessary, only for use in test code. + * + * <p><b>Do not use this interface</b> for public or protected declarations: + * it is a fig leaf for bad design, and it does not prevent anyone from using + * the declaration---and experience has shown that they will. + * If the method breaks the encapsulation of its class, then its internal + * representation will be hard to change. Review comment: Make sense, removed. ########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VisibleForTesting.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.util; + +/** + * Annotates a program element that exists, or is more widely visible than + * otherwise necessary, only for use in test code. + * + * <p><b>Do not use this interface</b> for public or protected declarations: + * it is a fig leaf for bad design, and it does not prevent anyone from using + * the declaration---and experience has shown that they will. + * If the method breaks the encapsulation of its class, then its internal + * representation will be hard to change. Review comment: Makes sense, removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
