virajjasani commented on pull request #3505:
URL: https://github.com/apache/hadoop/pull/3505#issuecomment-933171989
> Adjust to the VFT in Guava, we may want to annotate it with the following
annotations.
>
> ```
> @Retention(RetentionPolicy.CLASS)
> @Target({ElementType.TYPE, ElementType.METHOD})
> @Documented
> ```
Thanks @tasanuma. I tried to adjust it to the one defined here
https://github.com/google/guava/blob/master/guava/src/com/google/common/annotations/VisibleForTesting.java
But now I see that
[GwtCompatible](https://github.com/google/guava/blob/master/guava/src/com/google/common/annotations/GwtCompatible.java)
annotation itself has the Retention and Target annotations so they should be
applied to VFT as well. Let me make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
