steveloughran commented on pull request #3505:
URL: https://github.com/apache/hadoop/pull/3505#issuecomment-932147785


   If we are going to change the javadocs, maybe make clear this is a guava 
replacement and what guarantees we offer (none). Here's my draft
   
   ```java
     /**
      * Annotates a program element that exists, or is more widely visible than
      * otherwise necessary, for the benefits of testability.
      * More specifically <i>testability within the hadoop-* modules</i>.
      * This gives the implicit scope and stability of:
      * <pre>
      * @InterfaceAudience.Private
      * @InterfaceStability.Unstable
      * </pre>
      * If external modules need to access/override these methods, then
      * they MUST be rescoped as public/limited private.
      */
   ```
   
   Now, should we actually move this to the package 
`org.apache.hadoop.classification` in the module `hadoop-annotations`? It is a 
classification, after all. I think from a consistency perspective, it makes 
sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to