[
https://issues.apache.org/jira/browse/HADOOP-17952?focusedWorklogId=660442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-660442
]
ASF GitHub Bot logged work on HADOOP-17952:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/21 16:44
Start Date: 05/Oct/21 16:44
Worklog Time Spent: 10m
Work Description: virajjasani commented on pull request #3503:
URL: https://github.com/apache/hadoop/pull/3503#issuecomment-934579871
> Is there a need to introduce a new dependency
`restrict-imports-enforcer-rule` ? Hadoop repo used checkStyle import
configurations to guard against `IllegalImport` including `illegalPkgs` and
`illegalClasses`.
>
> Either way, we should have a single interface to define the list of
imports.
@amahussein We are already using this dependency in parent pom. Also, even
though checkstyle rule fails, we can't prevent someone from using this import.
With this dependency, the build will fail if someone uses this dependency in
hadoop-common modules. The eventual goal is to remove project level
dependencies and put it only in parent pom as part of final PR.
This is what we have followed in previous commits as well. For instance,
#3087 and #3049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 660442)
Time Spent: 1h (was: 50m)
> Replace Guava VisibleForTesting by Hadoop's own annotation in
> hadoop-common-project modules
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-17952
> URL: https://issues.apache.org/jira/browse/HADOOP-17952
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
