[
https://issues.apache.org/jira/browse/HADOOP-17952?focusedWorklogId=660519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-660519
]
ASF GitHub Bot logged work on HADOOP-17952:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/21 19:04
Start Date: 05/Oct/21 19:04
Worklog Time Spent: 10m
Work Description: virajjasani commented on pull request #3503:
URL: https://github.com/apache/hadoop/pull/3503#issuecomment-934689963
> > I think since we replace Guava dependencies of specific classes one
module at a time, I think it makes sense to push corresponding pom changes for
the relevant poms so that in the meantime no one else can commit changes using
illegal imports before we are done making changes for all pom modules. And of
course, at the end, we will remove plugin from individual modules and put it at
parent pom only.
>
> This process is what we did in
[HADOOP-17098](https://issues.apache.org/jira/browse/HADOOP-17098) to reduce
Guava Lists and Guava Sets, and I agree with this approach again.
Thanks @tasanuma.
> Anyway, since #3087 and #3049 are already in, then the way to move forward
is 1- to proceed with this PR; 2- to file a new jira to migrate
`checkStyle.illegalImports` to the parent pom file. For sake of coherence and
consistency, this jira has to be merged before any further changes to
bannedImports in all pom files.
Thanks @amahussein, makes sense. Will create Jira to migrate
`checkStyle.illegalImports` to parent pom file 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 660519)
Time Spent: 2.5h (was: 2h 20m)
> Replace Guava VisibleForTesting by Hadoop's own annotation in
> hadoop-common-project modules
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-17952
> URL: https://issues.apache.org/jira/browse/HADOOP-17952
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
