[
https://issues.apache.org/jira/browse/HADOOP-17952?focusedWorklogId=660479&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-660479
]
ASF GitHub Bot logged work on HADOOP-17952:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/21 17:33
Start Date: 05/Oct/21 17:33
Worklog Time Spent: 10m
Work Description: virajjasani commented on pull request #3503:
URL: https://github.com/apache/hadoop/pull/3503#issuecomment-934618075
> It would be good to have a jira to move the above guava classes to the
bannedImports if it is not already there.
Agree, makes sense.
> The problem with those pom changes being pushed now is that the guava
changes becomes sort of invasive making changes to pom files of each module.
Pushing those changes after a major milestone would mean only one Jira and one
PR (i.e., HADOOP-XYZ: migrating banned imports to use
restrict-imports-enforcer-rule).
I think since we replace Guava dependencies of specific classes one module
at a time, I think it makes sense to push corresponding pom changes for the
relevant poms so that in the meantime no one else can commit changes using
illegal imports before we are done making changes for all pom modules. And of
course, at the end, we will remove plugin from individual modules and put it at
parent pom only. Do you not think this is the right approach? Only if we are to
make changes for all modules in one shot (one Jira, one PR), we can directly
put plugin in parent pom only. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 660479)
Time Spent: 1.5h (was: 1h 20m)
> Replace Guava VisibleForTesting by Hadoop's own annotation in
> hadoop-common-project modules
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-17952
> URL: https://issues.apache.org/jira/browse/HADOOP-17952
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
