aajisaka commented on a change in pull request #3789:
URL: https://github.com/apache/hadoop/pull/3789#discussion_r770428092
##########
File path: hadoop-project/pom.xml
##########
@@ -1150,26 +1165,6 @@
<artifactId>woodstox-core</artifactId>
<version>${woodstox.version}</version>
</dependency>
- <dependency>
- <groupId>org.codehaus.jackson</groupId>
- <artifactId>jackson-mapper-asl</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>org.codehaus.jackson</groupId>
- <artifactId>jackson-core-asl</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>org.codehaus.jackson</groupId>
- <artifactId>jackson-jaxrs</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>org.codehaus.jackson</groupId>
- <artifactId>jackson-xc</artifactId>
- <version>${jackson.version}</version>
- </dependency>
Review comment:
Jackson 1.x still exists in the dependency, so we need to keep this to
fix the version to 1.19.3. Remove these when upgrading Avro.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ProvidedVolumeImpl.java
##########
@@ -372,7 +373,7 @@ public void releaseReservedSpace(long bytesToRelease) {
private static final ObjectWriter WRITER =
new ObjectMapper().writerWithDefaultPrettyPrinter();
private static final ObjectReader READER =
- new ObjectMapper().reader(ProvidedBlockIteratorState.class);
+ new ObjectMapper().readerFor(ProvidedBlockIteratorState.class);
Review comment:
`READER` is not used and can be removed.
##########
File path: LICENSE-binary
##########
@@ -323,10 +323,6 @@ org.apache.kerby:kerby-xdr:1.0.1
org.apache.kerby:token-provider:1.0.1
org.apache.yetus:audience-annotations:0.5.0
org.apache.zookeeper:zookeeper:3.6.3
-org.codehaus.jackson:jackson-core-asl:1.9.13
-org.codehaus.jackson:jackson-jaxrs:1.9.13
-org.codehaus.jackson:jackson-mapper-asl:1.9.13
-org.codehaus.jackson:jackson-xc:1.9.13
Review comment:
LICENSE-binary should include all the dependencies in the binary
release. Now Jackson 1.9.13 is still used from Avro and the jar files exist in
binary tarball, so we should keep it as is. Let's remove it when we upgrade
Avro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
