virajjasani commented on pull request #3789:
URL: https://github.com/apache/hadoop/pull/3789#issuecomment-996509081
@aajisaka The spotbug warning is relevant to the `READER` that we removed in
the recent change and according to spotbugs, we can remove one more boolean
param `atEnd` from static class `ProvidedBlockIteratorState`. This field is
already annotated with `@JsonProperty`, hence I believe it's removal can be a
separate task if required and we might not need to take it up with this PR.
```
@JsonProperty
private boolean atEnd;
```
Does it sound good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
