virajjasani commented on a change in pull request #3789:
URL: https://github.com/apache/hadoop/pull/3789#discussion_r770620287



##########
File path: hadoop-project/pom.xml
##########
@@ -1150,26 +1165,6 @@
         <artifactId>woodstox-core</artifactId>
         <version>${woodstox.version}</version>
       </dependency>
-      <dependency>
-        <groupId>org.codehaus.jackson</groupId>
-        <artifactId>jackson-mapper-asl</artifactId>
-        <version>${jackson.version}</version>
-      </dependency>
-      <dependency>
-        <groupId>org.codehaus.jackson</groupId>
-        <artifactId>jackson-core-asl</artifactId>
-        <version>${jackson.version}</version>
-      </dependency>
-      <dependency>
-        <groupId>org.codehaus.jackson</groupId>
-        <artifactId>jackson-jaxrs</artifactId>
-        <version>${jackson.version}</version>
-      </dependency>
-      <dependency>
-        <groupId>org.codehaus.jackson</groupId>
-        <artifactId>jackson-xc</artifactId>
-        <version>${jackson.version}</version>
-      </dependency>

Review comment:
       Btw even if we remove this, we will still have 1.19.3 version coming 
from Avro:
   ```
   +-org.apache.hadoop:hadoop-common:3.4.0-SNAPSHOT
     +-org.apache.avro:avro:1.7.7
       +-org.codehaus.jackson:jackson-mapper-asl:1.9.13
   ```
   However, given that avro should be upgraded independent from whether 
jackson1 is still required by other Hadoop dependencies, I think it makes sense 
to not remove this block. Hence, reverted this change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to