ashutoshcipher edited a comment on pull request #3793: URL: https://github.com/apache/hadoop/pull/3793#issuecomment-996623640
> Thank you @ashutoshcipher for providing the patch. Some comments and questions: > > * Would you provide a new test case for this feature? > * Would you fix the checkstyle warnings? > * Can we use SLF4J parameterized logging format as possible? > > In addition, I have a question. Why `YarnConfiguration.RM_TIMELINE_SERVER_V1_PUBLISHER_INTERVAL` is set to 1 in some tests? > * Would you provide a new test case for this feature? Writing test case for this is tricky, may we can do that later. Also current tests cases are making sure the functionality is overall intact. > * Would you fix the checkstyle warnings? I will do that. > * Can we use SLF4J parameterized logging format as possible? I will do that. > In addition, I have a question. Why `YarnConfiguration.RM_TIMELINE_SERVER_V1_PUBLISHER_INTERVAL` is set to 1 in some tests? This param was introduced as part of this change, so updated in test cases with value 1 as internal to make sure overall functionality is intact for tests to check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
