aajisaka commented on a change in pull request #3793:
URL: https://github.com/apache/hadoop/pull/3793#discussion_r772141239
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisher.java
##########
@@ -72,9 +72,21 @@
public class TestSystemMetricsPublisher {
- protected static ApplicationHistoryServer timelineServer;
- protected static TimelineServiceV1Publisher metricsPublisher;
- protected static TimelineStore store;
+ public static void setTimelineServer(ApplicationHistoryServer
timelineServer) {
+ TestSystemMetricsPublisher.timelineServer = timelineServer;
+ }
+
+ public static void setMetricsPublisher(TimelineServiceV1Publisher
metricsPublisher) {
+ TestSystemMetricsPublisher.metricsPublisher = metricsPublisher;
+ }
+
+ public static void setStore(TimelineStore store) {
+ TestSystemMetricsPublisher.store = store;
+ }
Review comment:
The methods can be package-private (i.e. public should be removed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
