ashutoshcipher commented on pull request #3793: URL: https://github.com/apache/hadoop/pull/3793#issuecomment-997407365
> > Also current tests cases are making sure the functionality is overall intact. > > It is not true because the feature is not enabled by default. Would you create a new test case with the feature enabled? I am creating a new class `TestSystemMetricsPublisherInBatch` extending the `TestSystemMetricsPublisher` class, enabling the feature and adding these params `RM_TIMELINE_SERVER_V1_PUBLISHER_BATCH_ENABLED` and `RM_TIMELINE_SERVER_V1_PUBLISHER_INTERVAL` while `setup` > > > This param was introduced as part of this change, so updated in test cases with value 1 as internal to make sure overall functionality is intact for tests to check. > > By default, setting this parameter does not take effect. Yes, agreed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
