aajisaka commented on a change in pull request #3793:
URL: https://github.com/apache/hadoop/pull/3793#discussion_r772141862



##########
File path: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/TestSystemMetricsPublisherInBatch.java
##########
@@ -28,6 +28,10 @@
 
 public class TestSystemMetricsPublisherInBatch extends 
TestSystemMetricsPublisher {
 
+  private static ApplicationHistoryServer timelineServer;
+  private static TimelineServiceV1Publisher metricsPublisher;
+  private static TimelineStore store;
+

Review comment:
       The variables can be local.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to