virajjasani commented on a change in pull request #3843:
URL: https://github.com/apache/hadoop/pull/3843#discussion_r782081202
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
##########
@@ -68,8 +68,7 @@
* Enforcing the limit is required in order to avoid data-node
* running out of memory.
*/
- int maxXceiverCount =
- DFSConfigKeys.DFS_DATANODE_MAX_RECEIVER_THREADS_DEFAULT;
+ volatile int maxXceiverCount;
Review comment:
Looks like we need volatile for sure right? There might be slightest
chance for DataXceiverServer thread to throw limit exceeded error if this is
not volatile?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java
##########
@@ -365,4 +367,42 @@ public void testBlockReportIntervalReconfiguration()
.getConf().get(DFS_BLOCKREPORT_INTERVAL_MSEC_KEY));
}
}
+
+ @Test
+ public void testDataXceiverReconfiguration()
+ throws ReconfigurationException {
+ for (int i = 0; i < NUM_DATA_NODE; i++) {
+ DataNode dn = cluster.getDataNodes().get(i);
+
+ // Try invalid values.
+ try {
+ dn.reconfigureProperty(DFS_DATANODE_MAX_RECEIVER_THREADS_KEY, "text");
+ fail("ReconfigurationException expected");
+ } catch (ReconfigurationException expected) {
+ assertTrue("expecting NumberFormatException",
+ expected.getCause() instanceof NumberFormatException);
+ }
+ try {
+ dn.reconfigureProperty(DFS_DATANODE_MAX_RECEIVER_THREADS_KEY,
String.valueOf(-1));
+ fail("ReconfigurationException expected");
+ } catch (ReconfigurationException expected) {
+ assertTrue("expecting IllegalArgumentException",
+ expected.getCause() instanceof IllegalArgumentException);
+ }
+
+ // Change properties and verify change.
+ dn.reconfigureProperty(DFS_DATANODE_MAX_RECEIVER_THREADS_KEY,
String.valueOf(123));
+ assertEquals(String.format("%s has wrong value",
DFS_DATANODE_MAX_RECEIVER_THREADS_KEY),
+ 123, dn.getXferServer().getMaxXceiverCount());
+
+ // Revert to default.
+ dn.reconfigureProperty(DFS_DATANODE_MAX_RECEIVER_THREADS_KEY, null);
+ assertEquals(String.format("%s has wrong value",
DFS_DATANODE_MAX_RECEIVER_THREADS_KEY),
+ DFS_DATANODE_MAX_RECEIVER_THREADS_DEFAULT,
dn.getXferServer().getMaxXceiverCount());
+
+ assertEquals(String.format("expect %s is not configured",
Review comment:
Maybe use assertNull?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
