virajjasani commented on pull request #3843: URL: https://github.com/apache/hadoop/pull/3843#issuecomment-1012791850
> If we change `maxXceiverCount ` to `private`, we might have to change all places used it before. Yeah since it is not newly introduced and we are updating it to volatile, it's fine to leave it as is rather than making it private. I believe we can ignore this checkstyle warning in this case. +1 (non-binding) from my side. Thanks @tomscut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
