tomscut commented on a change in pull request #3843:
URL: https://github.com/apache/hadoop/pull/3843#discussion_r782645429
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
##########
@@ -68,8 +68,7 @@
* Enforcing the limit is required in order to avoid data-node
* running out of memory.
*/
- int maxXceiverCount =
- DFSConfigKeys.DFS_DATANODE_MAX_RECEIVER_THREADS_DEFAULT;
+ volatile int maxXceiverCount;
Review comment:
Thanks @virajjasani for your review. IMO, to ensure consistency across
threads, we need to make it volatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
