[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773808
]
ASF GitHub Bot logged work on HADOOP-18248:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 23:35
Start Date: 23/May/22 23:35
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879939590
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##########
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I think your suggestion is correct and should be changed to equal.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##########
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I think your suggestion is correct and should be changed to equal.
Issue Time Tracking
-------------------
Worklog Id: (was: 773808)
Time Spent: 3h 50m (was: 3h 40m)
> Fix Junit Test Deprecated assertThat
> ------------------------------------
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
