[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773483&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773483
]
ASF GitHub Bot logged work on HADOOP-18248:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 13:36
Start Date: 23/May/22 13:36
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134690674
> > Hi, @steveloughran please help me to review the code, thank you very
much!
> > lwe have these things called "holidays" and "weekends". do not take the
fact that i didn't review the change personally.
>
> it's mostly an HDFS source change. you need an hdfs jira for that bit of
the patch.
>
> for hadoop common, why not move it to assertj the way we are doing for new
code
Thanks for your suggestion, I will re-submit a HDFS JIRA and make some
adjustments to the code. Sorry for disturbing you
during the holiday.
Issue Time Tracking
-------------------
Worklog Id: (was: 773483)
Time Spent: 2h 50m (was: 2h 40m)
> Fix Junit Test Deprecated assertThat
> ------------------------------------
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
