[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773459&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773459
]
ASF GitHub Bot logged work on HADOOP-18248:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 12:39
Start Date: 23/May/22 12:39
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879390284
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##########
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static <T> void assertThat(String reason, T actual, Matcher<? super
T> matcher) {
+ MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Please add a short JavaDoc explaining why its here and when/if we can remove.
Something like
"Override `assertThat` introduced by extending JUnit `Assertions` in base
test class. If extending `Assertions` is removed, we can elimiate this method
and import directly."
Issue Time Tracking
-------------------
Worklog Id: (was: 773459)
Time Spent: 2.5h (was: 2h 20m)
> Fix Junit Test Deprecated assertThat
> ------------------------------------
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
