ahmarsuhail commented on code in PR #4458:
URL: https://github.com/apache/hadoop/pull/4458#discussion_r924708222


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/common/CachingBlockManager.java:
##########
@@ -330,6 +341,10 @@ private void readBlock(BufferData data, boolean 
isPrefetch, BufferData.State...
         this.read(buffer, offset, size);
         buffer.flip();
         data.setReady(expectedState);
+
+        if(isPrefetch) {
+          this.prefetchingStatistics.prefetchOperationCompleted();

Review Comment:
   So this was currently only measuring successful calls, I'm now also adding a 
count for failure. I can't figure out how to measure duration for a failure 
though, could you point me to an example? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to