xkrogen commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1216959253
It looks like the current diff is disallowing in-progress edits during `catchupDuringFailover()`. But this isn't right, we _do_ want in-progress edits, since those can be durable and have been ack'ed to clients. Right? I'm also a little confused because your [last comment](https://github.com/apache/hadoop/pull/4744#issuecomment-1215017852) says you solved the issue via `getEditLogManifest()`, but I don't see that method called at all in the current diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
