xkrogen commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1219804467
> Before `catchupDuringFailover`, whatever active crashed or successfully changed to standby, the last segment in majority journalnode should be finalized. If the active crashed, then the segment won't be finalized, right? > The same processing idea has also appeared in [HDFS-14806](https://issues.apache.org/jira/browse/HDFS-14806). [Here](https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java#L113) This is different. Bootstrap standby doesn't need to get _all_ transactions, it's more like a best-effort to load most of the transactions. Later, when the standby transitions to active, _then_ it will call `catchupDuringFailover` to load the remainder. Though generally I agree that the idea is similar. Perhaps we should add a way for callers of `QuorumJournalManager` to indicate that they want to use the streaming mechanism, as opposed to RPC. Disabling in-progress edits achieves this, but is too strong (note that the streaming mechanism can also load in-progress edits). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
