ZanderXu commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1221235271
@xkrogen Thanks. > I think you might have also understood what I was saying in my last comment Yes, I got it. > I am thinking we can add a new parameter to LogsPurgeable#selectInputStreams() like preferBulkReads. This is a good idea, I will fix this patch like this. > In recoverUnclosedStreams, if the finalization fails, it will just ignore it and assume that it will be handled later (by Journal#startLogSegment(), which will automatically close an old stream when you try to open a new one). > In recoverUnclosedStreams, if the finalization fails, it will just ignore it Sorry, I didn't notice this. But I think it's crazy. > assume that it will be handled later (by Journal#startLogSegment(), which will automatically close an old stream when you try to open a new one). I'm sorry, I just find this comment, but didn't find related code to finalize the previous inProgress segment. Can you share the related code? Thanks. > If there is something preventing the new active from communicating with the JNs, or something preventing the JNs from finalizing the old segment, then the NN will eventually fail to become active regardless. Yes, I agree. Standby should crash or fail to become active if it cannot finalize the old segment. About this case, How about fix it in a new PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
