Samrat002 commented on code in PR #4783:
URL: https://github.com/apache/hadoop/pull/4783#discussion_r951609588
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -839,18 +837,15 @@ private boolean handleShutdownOrResyncCommand(
if (response.getNodeAction() == NodeAction.SHUTDOWN) {
LOG.warn("Received SHUTDOWN signal from Resourcemanager as part of"
+ " heartbeat, hence shutting down.");
- LOG.warn("Message from ResourceManager: "
- + response.getDiagnosticsMessage());
+ LOG.warn("Message from ResourceManager: {}.",
response.getDiagnosticsMessage());
context.setDecommissioned(true);
dispatcher.getEventHandler().handle(
new NodeManagerEvent(NodeManagerEventType.SHUTDOWN));
return true;
}
if (response.getNodeAction() == NodeAction.RESYNC) {
- LOG.warn("Node is out of sync with ResourceManager,"
- + " hence resyncing.");
- LOG.warn("Message from ResourceManager: "
- + response.getDiagnosticsMessage());
+ LOG.warn("Node is out of sync with ResourceManager, hence resyncing.");
Review Comment:
Both can be combined into 1 `LOG.warn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
