ayushtkn commented on code in PR #4783:
URL: https://github.com/apache/hadoop/pull/4783#discussion_r966720430
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -1287,10 +1280,8 @@ public void verifyRMHeartbeatResponseForNodeLabels(
} else {
// case where updated labels from NodeLabelsProvider is sent to RM
and
// RM rejected the labels
- LOG.error(
- "NM node labels {" + StringUtils.join(",", getPreviousValue())
- + "} were not accepted by RM and message from RM : "
- + response.getDiagnosticsMessage());
+ LOG.error("NM node labels {{}} were not accepted by RM and message
from RM : {}.",
+ StringUtils.join(",", getPreviousValue()),
response.getDiagnosticsMessage());
Review Comment:
same as above for ``{{}}``
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -1136,9 +1130,8 @@ public void verifyRMHeartbeatResponseForNodeAttributes(
} else {
// case where updated node attributes from NodeAttributesProvider
// is sent to RM and RM rejected the attributes
- LOG.error("NM node attributes {" + getPreviousValue()
- + "} were not accepted by RM and message from RM : " + response
- .getDiagnosticsMessage());
+ LOG.error("NM node attributes {{}} were not accepted by RM and
message from RM : {}." ,
+ getPreviousValue(), response.getDiagnosticsMessage() );
Review Comment:
I am not sure about this ``{{}}``, give a check if it works they way you
want, in general it is very confusing can explore using `[{}]` as well
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java:
##########
@@ -625,7 +625,7 @@ public RegisterNodeManagerResponse registerNodeManager(
@Override
public NodeHeartbeatResponse nodeHeartbeat(NodeHeartbeatRequest request)
throws YarnException, IOException {
- LOG.info("Got heartBeatId: [" + heartBeatID +"]");
+ LOG.info("Got heartBeatId: [{}}]", heartBeatID);
Review Comment:
there are two `}}`, is that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
