slfan1989 commented on code in PR #4783:
URL: https://github.com/apache/hadoop/pull/4783#discussion_r966945533
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -1136,9 +1130,8 @@ public void verifyRMHeartbeatResponseForNodeAttributes(
} else {
// case where updated node attributes from NodeAttributesProvider
// is sent to RM and RM rejected the attributes
- LOG.error("NM node attributes {" + getPreviousValue()
- + "} were not accepted by RM and message from RM : " + response
- .getDiagnosticsMessage());
+ LOG.error("NM node attributes {{}} were not accepted by RM and
message from RM : {}." ,
+ getPreviousValue(), response.getDiagnosticsMessage() );
Review Comment:
I agree with you, I will modify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
